Add option to incorporate analytical correction into dials.scale models#2313
Merged
jbeilstenedmands merged 4 commits intodials:mainfrom Jan 12, 2023
Merged
Conversation
dagewa
pushed a commit
that referenced
this pull request
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to use a pre-calculated analytical correction as part of scaling models.
First motivated by the use case of using a pre-calculated analytical absorption model, one could potentially want to model other effects, so this a more general solution.
If the option
analytical_correction=Trueis set for a given model, then the model will use the values from a column namedanalytical_correctionin the reflection table as an additional multiplier for the scale factors.