Skip to content

dials.image_viewer: remove basis vector display#2484

Merged
ndevenish merged 7 commits intomainfrom
2480-dialsimage_viewer-basis-vector-display-is-problematic
Aug 11, 2023
Merged

dials.image_viewer: remove basis vector display#2484
ndevenish merged 7 commits intomainfrom
2480-dialsimage_viewer-basis-vector-display-is-problematic

Conversation

@dagewa
Copy link
Copy Markdown
Member

@dagewa dagewa commented Aug 4, 2023

This was found to be problematic and not useful, so this PR removes it. As a side-effect, the settings panel is also now a couple of rows shorter, which helps with #2142

@dagewa dagewa linked an issue Aug 4, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2023

Codecov Report

Merging #2484 (1fab9f1) into main (4b86bb6) will increase coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is 72.38%.

❗ Current head 1fab9f1 differs from pull request most recent head 0178607. Consider uploading reports for the commit 0178607 to get more accurate results

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
+ Coverage   78.61%   78.69%   +0.08%     
==========================================
  Files         607      608       +1     
  Lines       74440    74477      +37     
  Branches    10134    10131       -3     
==========================================
+ Hits        58518    58611      +93     
+ Misses      13759    13700      -59     
- Partials     2163     2166       +3     

@ndevenish ndevenish enabled auto-merge (squash) August 11, 2023 08:55
@ndevenish ndevenish merged commit 62df901 into main Aug 11, 2023
@ndevenish ndevenish deleted the 2480-dialsimage_viewer-basis-vector-display-is-problematic branch August 11, 2023 12:22
toastisme pushed a commit to toastisme/dials that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dials.image_viewer basis vector display is problematic

3 participants