dials.image_viewer: remove basis vector display#2484
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
==========================================
+ Coverage 78.61% 78.69% +0.08%
==========================================
Files 607 608 +1
Lines 74440 74477 +37
Branches 10134 10131 -3
==========================================
+ Hits 58518 58611 +93
+ Misses 13759 13700 -59
- Partials 2163 2166 +3 |
toastisme
pushed a commit
to toastisme/dials
that referenced
this pull request
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found to be problematic and not useful, so this PR removes it. As a side-effect, the settings panel is also now a couple of rows shorter, which helps with #2142