Data id fix#2681
Merged
amyjaynethompson merged 5 commits intodials:mainfrom Jun 25, 2024
Merged
Conversation
jbeilstenedmands
approved these changes
Jun 21, 2024
Contributor
jbeilstenedmands
left a comment
jbeilstenedmands
left a comment
There was a problem hiding this comment.
Thanks for adding the test, looks good!
graeme-winter
pushed a commit
that referenced
this pull request
Nov 19, 2024
fix data ids output by json file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug when outputting the json file from dials.correlation_matrix that was causing the multiplex tests to fail when called by xia2. Correct dataset ids now output in json file.