Update dials.refine_error_model to allow grouped and individual refinements#2685
Merged
Update dials.refine_error_model to allow grouped and individual refinements#2685
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
+ Coverage 78.08% 78.10% +0.02%
==========================================
Files 618 618
Lines 76935 76969 +34
Branches 8956 8964 +8
==========================================
+ Hits 60075 60117 +42
+ Misses 14613 14603 -10
- Partials 2247 2249 +2 |
graeme-winter
pushed a commit
that referenced
this pull request
Nov 19, 2024
…2685) When this feature was implemented in dials.scale, the corresponding updates to dials.refine_error_model were overlooked. Add grouped and individual refinements to this program also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this feature was implemented in
dials.scale, the corresponding updates todials.refine_error_modelwere overlooked. This PR adds grouped and individual refinements to this program also.