dials.generate_distortion_maps: much faster generation of elliptical distortion maps#2745
Merged
dials.generate_distortion_maps: much faster generation of elliptical distortion maps#2745
dials.generate_distortion_maps: much faster generation of elliptical distortion maps#2745Conversation
…ocal scope instead
a private copy of the panel or ellipse matrix
…e system. So continue to calculate that in Python and pass in to the C++ object
centre to the beam centre automatically
Member
Author
|
Nevertheless, the maps remain useless because of #2744 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
==========================================
- Coverage 78.15% 78.14% -0.01%
==========================================
Files 617 618 +1
Lines 76731 76726 -5
Branches 8930 8929 -1
==========================================
- Hits 59968 59957 -11
- Misses 14528 14532 +4
- Partials 2235 2237 +2 |
graeme-winter
pushed a commit
that referenced
this pull request
Nov 19, 2024
…l distortion maps (#2745) Move algorithm to C++ for >50* faster version of the elliptical distortion map calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the loop over pixels from Python to C++. For a large detector (Gatan K3,$4092 \times 5760$ pixels) this reduced the whole program run time from 2m56.584s to just 0m3.203s (i.e. 55 times speed improvement).
In addition, set sensible defaults for ellipse map generation, including automatic ellipse centring at the beam centre.