Improve stability for test_export_best.py#2791
Merged
jbeilstenedmands merged 3 commits intomainfrom Nov 6, 2024
Merged
Conversation
graeme-winter
pushed a commit
that referenced
this pull request
Nov 19, 2024
Improve stability and runtime for test_export_best.py by starting at integrated data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start the test to run on an example dataset for which we have integrated data available in dials_data, rather than running the whole processing starting from dials.import. This meant that any changes to a program that causes the results to change can cause this unrelated test to start failing due to the comparison of the precise line-by-line output in export, which I have experienced before and has been seen once again (#2790).
Also for me this reduces the runtime of this test from 22s to 3s.