Conversation
Before this made a lot of references to models.expt without being clear _which_ experiment file to use. Edit to make this more explicit and also reflect some of the changes in semi-recent history e.g. exporting scaled data.
dagewa
requested changes
Mar 12, 2025
Member
dagewa
left a comment
dagewa
left a comment
There was a problem hiding this comment.
A few suggestions to correct typos and simplify language.
Member
|
I've pushed my suggestions |
Member
|
These were ordered-set failures previously |
biochem-fan
pushed a commit
that referenced
this pull request
Apr 24, 2025
Before this made a lot of references to models.expt without being clear _which_ experiment file to use. Edit to make this more explicit and also reflect some of the changes in semi-recent history e.g. exporting scaled data. Co-authored-by: David Waterman <dagewa@users.noreply.github.com>
ndevenish
pushed a commit
that referenced
this pull request
Dec 9, 2025
Before this made a lot of references to models.expt without being clear _which_ experiment file to use. Edit to make this more explicit and also reflect some of the changes in semi-recent history e.g. exporting scaled data. Co-authored-by: David Waterman <dagewa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this made a lot of references to
models.exptwithout being clear which experiment file to use. Edit to make this more explicit and also reflect some of the changes in semi-recent history e.g. exporting scaled data.