Convert remaining tests to use dials-data rather than dials_regression#2915
Merged
Convert remaining tests to use dials-data rather than dials_regression#2915
dials-data rather than dials_regression#2915Conversation
…data, but then xfail the test because it does not appear to work correctly (#2909)
Member
Author
|
The test errors are a dumb thing fixed by dials/data#506. I'll try again tomorrow when a new version of |
ndevenish
pushed a commit
that referenced
this pull request
Dec 9, 2025
…sion` (#2915) This completes the full transition to `dials-data` for DIALS tests, such that no tests use data on `dials_regression/` any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the conversion of DIALS tests to use
dials-data(for #2880). In some cases tests were pointed to close copies of the original files (generally updated to modern.{expt,refl}format, renamed, and path records edited). In other cases the tests were changed to use files already ondials-datato avoid excessive increases in the size of data downloaded bydials-data.Mostly this was straightforward. One exception is
test_filter_overlaps.py, which does not appear to function as expected when the test data set was changed. Seeing as we believe this functionality to be broken anyway (#2909) it seems reasonable toxfailthe test at this point.This PR will be followed by a similar one for
dxtbx, and then a further pair of PRs to remove thedials_regressionfixtures fromconftest.pyfiles.