Implement baseline ReflectionTable with eager HDF5 loading#10
Merged
dimitrivlachos merged 38 commits intomainfrom May 15, 2025
Merged
Implement baseline ReflectionTable with eager HDF5 loading#10dimitrivlachos merged 38 commits intomainfrom
dimitrivlachos merged 38 commits intomainfrom
Conversation
0d161f8 to
5e62e92
Compare
8c60fd5 to
faa1918
Compare
042fd7f to
b8a9fde
Compare
Collaborator
Author
|
Yes, you are correct @jbeilstenedmands. I am currently working on this while integrating this PR into the Fast Feedback Service and will push those changes once they are working. |
d682a67 to
d9ba0c7
Compare
jbeilstenedmands
approved these changes
May 9, 2025
Contributor
jbeilstenedmands
left a comment
There was a problem hiding this comment.
Thanks for undertaking this extensive piece of work, this looks really nice and functions well. I have verified that I can create and save h5 files that can be read by dials, so I think this can now be merged in.
f312cd6 to
e924310
Compare
ndevenish
reviewed
May 15, 2025
ndevenish
reviewed
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a canonical implementation of the
ReflectionTable,where all datasets are eagerly loaded into memory. While not optimized
for large-scale performance, this version provides a correct and
complete foundation for future enhancements such as lazy or chunked
loading. It simplifies the data model and establishes the foundation for
the public API and testing interface.
ReflectionTableclass that eagerly loads HDF5 datasetsinto memory.
read_array_with_shape_from_h5_file().h5read_processed.hppto support recursive group traversal,metadata extraction, and shape-aware reading.
write_raw_data_to_h5_file()and related helpers inh5write.hppfor raw and high-level writing with shape/attribute support.
h5dispatch.hppto centralize C++/HDF5 type dispatch andregistration.
mdspanbackport for flexible memory views.utils.h.loading, and column type access.