Fixed a small bug in case the server responds with UT8 responses.#31
Merged
dib0 merged 2 commits intodib0:masterfrom Mar 4, 2026
Merged
Fixed a small bug in case the server responds with UT8 responses.#31dib0 merged 2 commits intodib0:masterfrom
dib0 merged 2 commits intodib0:masterfrom
Conversation
Author
|
For example an A19 where the response contains a patient name with UTF-8 characters (eg. "TÉST PÁTIENT") will now decode correctly. |
Owner
|
Thanks! The creation of anew release will have to wait until this weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not change the ValidateMLLPMessage based on the stringbuilder but this can also be done on the byte array thus removing the need for the stringbuilder altogether.
This code also assumes if you instantiate the client with an encoding that the server will answer in the same encoding, if none provided UTF-8 is assumed.