Conversation
Agent-Logs-Url: https://github.com/didoo/figma-api/sessions/be1707a4-ae63-482d-a451-b9ddabaab348 Co-authored-by: didoo <686239+didoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix removal of svg_outline_text parameter in getImages query
Preserve explicit Apr 22, 2026
false/0 query values in toQueryParams (fixes getImages svg_outline_text=false)
didoo
reviewed
Apr 22, 2026
Agent-Logs-Url: https://github.com/didoo/figma-api/sessions/54a2c593-a132-4269-b099-fd5e88559b7f Co-authored-by: didoo <686239+didoo@users.noreply.github.com>
Owner
|
@copilot can you remove the files under the |
didoo
reviewed
Apr 22, 2026
Owner
There was a problem hiding this comment.
@copilot can you remove the files under the lib/ folder from this PR? these are the compiled files, and will be added (rebuilt) before the new version release in separate commits
Agent-Logs-Url: https://github.com/didoo/figma-api/sessions/241ba9e6-c286-4c50-8619-218406e46f6d Co-authored-by: didoo <686239+didoo@users.noreply.github.com>
didoo
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getImagesrequests were droppingsvg_outline_text=falsebecause query serialization filtered values using truthiness. This caused explicit boolean/number flags to be omitted from outbound Figma API URLs.Query serialization behavior
toQueryParamsto retain explicitfalseand0values.undefined,null, empty-string values, and empty keys.Endpoint-level regression coverage
getImagesApitest assertingsvg_outline_text=falseis preserved in the generated URL.Utility-level regression coverage
disabled=false.{ svg_outline_text: false, scale: 0 }.