Aries controller package failing

[Pieter-Uys]

Hey guys - I was playing around with the package trying to see how it works but it kept on failing because the requirement.txt was named requires.txt and it couldn't find the dependencies to install

I went and renamed the file and moved it into the root of the folder and .tar it again as well as .gz it as well ran pip install and it worked

here is the new updated version

ariespackage0.1.4.tar.gz

[wip-abramson]

The requirement.txt is not named requires.txt?

If you want to use the package you can just pip install it - https://pypi.org/project/aries-cloudcontroller/

If you want to learn how to use this package you are best starting with these tutorials https://github.com/OpenMined/PyDentity/tree/master/tutorials

[Pieter-Uys]

Hey @wip-abramson

The problem is when you run pip install aries-cloudcontroller it fails saying that it can't find the requirements.txt file that's why I unpacked it, renamed it to requirements.txt, and moved it to the root directory after doing so it worked perfectly.

Not sure if its something on my side but I am trying to recreate it in a virtualenv

[wip-abramson]

Hmm really weird, I have been installing this regularly in a docker environment and not had any issues.

What version of Python do you have installed?

[Pieter-Uys]

I got it right to recreate it in a virtualenv

I have Python 3.8.9 installed I tried this with older version 3.7.7 as well and it gave the same error I then upgraded to 3.8.9 and the same thing occurred again

Just to clarify when you do run pip install aries-cloudcontroller then it says that it can find the package for some reason 🤷🏻

but if you download the .tar.gz file and then you run it with pip install then you get that output in the image

[wip-abramson]

Hmm weird, yep I just reproduced this too in a venv. Must be something wrong with our build process.

@morrieinmaas any ideas?

[Pieter-Uys]

it's fixed here (As my initial post)
ariespackage0.1.4.tar.gz

[wip-abramson]

Thanks!

But we want it to be fixed on pip, and it would be good to know how it got broken on pip so we don't do it again.

Also, strange that I never ran into any issues using this package in docker. Maybe I already had a local version.

[lohanspies]

@wip-abramson how did you reproduce the issue? Want to test on my side.

[wip-abramson]

Created a venv and tried to pip install the package

[lohanspies]

Yeah if you download the zip file the requirements.txt is renamed to requires.txt in the .egg-info folder.

https://blog.miguelgrinberg.com/post/the-package-dependency-blues and https://medium.com/knerd/best-practices-for-python-dependency-management-cc8d1913db82 provide more details.

[morrieinmaas]

This should not be closed. The PR should have closed 34 nd 36 - not this one.

Generally will have a look at this issue this week. @wip-abramson @lohanspies hope that's all right.

[morrieinmaas]

I'm a little confused as to what the problem is here really. you can run python -m pip install -e . in the root of the project and all is fine (or leave out the -e flag for editable).