Init Webhook Server - Bug?

[wip-abramson]

Hey,

Just been playing.

It seems I can run init_webhook_server, without passing in any arguments and it's doesn't throw and error.

Feels like we need some better handling of this. Like when I init the webhook server I want to know its been initalised successfully really. I again feel myself thinking that perhaps init and listen should be combined? Or at least some check and confirmation that the right arguments have been passed in.

Thoughts?

[morrieinmaas]

Agreed I'll look into that. not sure how to do that best from the top of my head.

[morrieinmaas]

Ah alright I see. So to address the not passing arg situation we should be able to simply not define default values like we do now

webhook_host: str = None,
webhook_port: int = None,
webhook_base: str = ""):

that's why it doesn't throw an error. Have you tried calling listen_webhooks() on the controller with the empty args webhook server? Because that should fail then and raise an exception.

Not sure about combining it to be honest, but also not opinionated. I mean the init_webhook_server really just instantiate the webhookserver class object and the listen_webhooks then tells it to act. I think it's a tricky question.

[morrieinmaas]

Proposed changes are on this branch

Let me know if you see any issues with that. If not I can change the tutorials in Pydentity accordingly after merge.

[wip-abramson]

Looks perfect. Minor thing - can we log the webhook server URL.

aries-cloudcontroller-python/aries_cloudcontroller/aries_controller.py

Line 65 in 4aa4366

logger.info("Webhook server started.")

including if in multitenant mode

[morrieinmaas]

yes we can. wil push changes in a minute.