Skip to content

Refactor webpack to accept svg imports #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caiulucas wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor webpack to accept svg imports #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
231d125
Refactor webpack to accept svg imports
caiulucas Mar 24, 2022
87a2f25
feat: add configuration to accept to accept svg imports
caiulucas Mar 24, 2022
dae217b
Merge branch 'refactor-webpack-to-accept-svg-imports' of https://gith…
caiulucas Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/reactjs-icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion src/@types/image.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
declare module '*.png';
declare module '*.jpeg';
declare module '*.jpg';
declare module '*.gif';
declare module '*.gif';
declare module '*.svg';
3 changes: 2 additions & 1 deletion src/components/Greetings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Button } from '../Button'
import { Container, Image, Text } from './styles'
import ReactIcon from '../../../assets/reactjs-icon.svg';

export function Greetings() {
function handleSayHello() {
Expand All @@ -11,7 +12,7 @@ export function Greetings() {
return (
<Container>
<Image
src="https://www.vectorlogo.zone/logos/reactjs/reactjs-icon.svg"
src={ReactIcon}
alt="ReactJS logo"
/>
<Text>An Electron boilerplate including TypeScript, React, Jest and ESLint.</Text>
Expand Down
2 changes: 1 addition & 1 deletion webpack/rules.webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = [
}
},
{
test: /\.(png|jpe?g|gif)$/i,
test: /\.(png|jpe?g|gif|svg)$/i,
loader: 'file-loader',
options: {
name: '[path][name].[ext]',
Expand Down