implement equality for vector of primitives (#6)_5#269
Merged
Conversation
sahithiacn
force-pushed
the
evm-6
branch
4 times, most recently
from
efcb686 to
d9dbe2e
Compare
Contributor
Author
|
/canary |
bors-diem
pushed a commit
that referenced
this pull request
Dec 5, 2022
Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com> Closes: #269
|
☀️ Canary successful |
sahithiacn
changed the title
|
Not approving until, better description of test coverage needed |
dhaneshacn
previously approved these changes
Dec 7, 2022
Contributor
Author
|
/land |
Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com> Closes: diem#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds to move-to-yul compiler equality comparison for vectors of primitives, such as vector.
Have you read the Contributing Guidelines on pull requests?
Yes
Testplan
Added unit test cases for this PR code changes refer
language/evm/move-to-yul/tests/Vectors.move