Skip to content

Revert "Added Dockerfile and accessing mdx2 through Docker container"#59

Merged
jlee733 merged 1 commit intomainfrom
revert-57-jlee-org-launch
Mar 20, 2026
Merged

Revert "Added Dockerfile and accessing mdx2 through Docker container"#59
jlee733 merged 1 commit intomainfrom
revert-57-jlee-org-launch

Conversation

@jlee733
Copy link
Copy Markdown

@jlee733 jlee733 commented Mar 20, 2026

-This PR is being reverted to keep this repo in sync with the Ando Lab's mdx2 repo
-The files being deleted will be moved to the 'mdx2-workflows' repo
Reverts #57

Summary by CodeRabbit

  • Chores

    • Removed Docker containerization infrastructure including Dockerfile configuration, Docker Hub build automation workflows, and container-specific ignore rules.
  • Documentation

    • Installation instructions have been updated to focus exclusively on conda/micromamba-based environment setup. Docker container-based installation is no longer available or documented.

@jlee733 jlee733 requested review from bielj and spmeisburger March 20, 2026 19:11
@jlee733 jlee733 self-assigned this Mar 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 838294e5-bb00-4ed3-9bb2-b4d309d8dc70

📥 Commits

Reviewing files that changed from the base of the PR and between 9570c85 and 091367b.

📒 Files selected for processing (4)
  • .dockerignore
  • .github/Dockerfile
  • .github/workflows/docker.yml
  • README.md
💤 Files with no reviewable changes (3)
  • .dockerignore
  • .github/Dockerfile
  • .github/workflows/docker.yml

Walkthrough

Removal of Docker-related infrastructure and configuration: eliminates .dockerignore, .github/Dockerfile, .github/workflows/docker.yml, and Docker setup documentation from README.md. This disables Docker image building and distribution workflows from the repository.

Changes

Cohort / File(s) Summary
Docker Infrastructure
.dockerignore, .github/Dockerfile, .github/workflows/docker.yml
Removes Docker build context configuration, multi-stage Dockerfile with JupyterLab setup, and GitHub Actions workflow that built and pushed Docker images to Docker Hub.
Documentation
README.md
Removes Docker-based developer installation section and Docker Hub image pull instructions from prerequisites; retains conda-based setup guidance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • PR #57: Reverses prior Docker-related additions by deleting the same Dockerfile, workflow, and README Docker content.
  • PR #58: Also removes Docker artifacts (Dockerfile(s), GitHub Actions docker workflow, and Docker usage documentation).
  • PR #38: Modifies Docker/CI setup by editing the same workflow file and Dockerfile path that are now deleted here.

Suggested reviewers

  • bielj
  • spmeisburger
  • saada

Poem

🐰 Docker containers fade away,
No more images in the bay,
Conda's path remains pristine,
Simpler workflows, lean and clean! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting Docker-related files and configurations that were previously added in PR #57.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-57-jlee-org-launch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting to generate walkthrough in a markdown collapsible section.

@jlee733 jlee733 merged commit 542f0f1 into main Mar 20, 2026
1 check passed
@jlee733 jlee733 deleted the revert-57-jlee-org-launch branch March 20, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant