fix color issue #113
Merged
fix color issue #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
NB: actually I gave a wrong name to the issue, CalculateNormals doesn't remove the colors, it adds the normals, and therefore goes around the issue we had. So This PR fixes the issue we had identified, but the issue wasn't exactly correctly identified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR concerns the color issue that is due to overloading problem:
RhinoCommons has an overloading with two AddRange methods that both thake two lists: one with locations and normals, ans the other with locations and colors. But when using the method with locations and colors, the one with locations and normals is called, triggering an error of conversion between RGB values and vector of doubles.
The fix first creates a point cloud with the locations, then adds the colors afterwards. It's a workaround, but it works.
