-
Notifications
You must be signed in to change notification settings - Fork 4
per-joint segmentation works at joint face level #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…as well as the joint faces individually
… backend for face-level analysis
|
@eleniv3d , @9and3 , @mariklad This PR still needs the documentation (which I will do tomorrow, saturday, I promise), but the rest is working fine: we have the data to make a face-per-face analysis ! I leave it as "Draft" until the documentation is done |
Hello @DamienGilliard thank you a lot for this push! I'll take care of the documentation and few fixes no worries, many thanks again it looks already very nice! 👐 |
9and3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some tiny cleaning, I also believe that there are parts in the segmentation backend that could be refactored to improove the performance but this is for another day :)
the major point I modified is this one:
I fixed this @DamienGilliard (and for later @eleniv3d ). Now faces export ghtrees by converting it to ghtree, it's acutally quite simple:
import ghpythonlib.treehelpers as th
gh_tree = th.list_to_tree(py_nlist)Maybe @eleniv3d in the computational error component you will have to reconvert it and you might have some surprise to deal with the input types (since this can be now a ghtree and hot only ghlist). In any case I am merging this, thanks again @DamienGilliard !

This PR concerns the modifications to the joint segmentator needed to have metrics for each joint face
It modifies the DFJointSegmentator:
when flattening the list of lists:

It also modifies a bit the DFCADSegmentator, because it also uses the same c++ back-end that has been slightly modified and thus requires some tweeking but only on the surface.