Registrations wraps/components + downsample components#18
Conversation
… glb_lcl_registration_wrap
…g and parameters adaptation mechanism
9and3
changed the title
|
Hello! This PR is ready! Happy to integrate your suggestions if you have!
Cheers! |
There was a problem hiding this comment.
Not intentional, yes ?
| * | ||
| * @param source the source diffCheck point cloud | ||
| * @param target the target diffCheck point cloud | ||
| * @param voxelize whether to voxelize the point clouds before computing the FPFHFeatures. A higher value will result in a more coarse point cloud (less resulting points). |
There was a problem hiding this comment.
Oups, thanks for spotting that !
| @@ -20,7 +20,7 @@ PYBIND11_MODULE(diffcheck_bindings, m) { | |||
| submodule_test.def("test", &test, "Simple function testing a vanilla python bindings."); | |||
There was a problem hiding this comment.
Simple question, why do you keep a "test" submodule ?
There was a problem hiding this comment.
just to have a simple test component that we can import to see if everythin is alright. It's more of an utility than anything else.
| elif RhinoDoc.ModelUnitSystem == Rhino.UnitSystem.Inches: | ||
| unit_scale = 0.0254 | ||
| elif RhinoDoc.ModelUnitSystem == Rhino.UnitSystem.Feet: | ||
| unit_scale = 0.3048 | ||
| elif RhinoDoc.ModelUnitSystem == Rhino.UnitSystem.Yards: | ||
| unit_scale = 0.9144 |
|
|
||
| # rotation | ||
| rotation = df_xform.rotation_matrix | ||
| rh_xform = rh_xform * rg.Transform.Rotation(rotation[0], rg.Vector3d(rotation[1], rotation[2], rotation[3]), rg.Point3d(0, 0, 0)) |
There was a problem hiding this comment.
Are you sure this works ? The DFTransformation.RotationMatrix is a 3x3 matrix, so I don't understand what happens here. From the Rhino Common API i suppose you use this constructor : https://developer.rhino3d.com/api/rhinocommon/rhino.geometry.transform/rotation#(vector3d,vector3d,point3d) but rotation[1], rotation[2] and rotation[3] are not doubles or int, they should be lines of the matrix and rotation[3] should be out of range, so as I read it, it will not work as intended, but I am probably wrong.
There was a problem hiding this comment.
Amazing work, thanks for letting me the time to go through this @9and3 . Very happy to dive again into python bindings. I still have a lot of work to fully understand the ghcomponentizer and pyperizer. I'll reserve a few hours for that during my vacations ;)
thank you for going through it! It's always better to have a pair of eyes more :) thanks !👐 |
2 participants
This PR introduces:
ghcomponentize.pyto comment automatically main block and flagging#r: diffCheck==0.0.1only for release #19 ).downsampling example:
icp registration example:
