Skip to content

two further instances of symbol_type #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018
Merged

two further instances of symbol_type #2742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/util/rename_symbol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ bool rename_symbolt::rename(typet &dest) const
}
}
}
else if(dest.id()==ID_symbol)
else if(dest.id() == ID_symbol_type)
Copy link
Contributor

@thk123 thk123 Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As (now!) per coding standards these should be can_cast_type<symbol_typet>(dest)

{
type_mapt::const_iterator it=
type_map.find(to_symbol_type(dest).get_identifier());
Expand Down Expand Up @@ -253,7 +253,7 @@ bool rename_symbolt::have_to_rename(const typet &dest) const
return true;
}
}
else if(dest.id()==ID_symbol)
else if(dest.id() == ID_symbol_type)
{
const irep_idt &identifier = to_symbol_type(dest).get_identifier();
return type_map.find(identifier) != type_map.end();
Expand Down