Skip to content

simplify how graphml error witnesses are built #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

simplify how graphml error witnesses are built #2824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions src/goto-programs/graphml_witness.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,24 +278,17 @@ void graphml_witnesst::operator()(const goto_tracet &goto_trace)
}

if(it->type==goto_trace_stept::typet::ASSIGNMENT &&
it->lhs_object_value.is_not_nil() &&
it->full_lhs_value.is_not_nil() &&
it->full_lhs.is_not_nil())
{
if(!it->lhs_object_value.is_constant() ||
!it->lhs_object_value.has_operands() ||
!has_prefix(id2string(it->lhs_object_value.op0().get(ID_value)),
"INVALID-"))
Copy link
Collaborator

@tautschnig tautschnig Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sanity check is now missing.

Copy link
Collaborator Author

@kroening kroening Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we haven't been generating these INVALID-OBJECTS for quite a while.

Copy link
Collaborator

@tautschnig tautschnig Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust this is true, but what change was it that made those go away?

{
xmlt &val=edge.new_element("data");
val.set_attribute("key", "assumption");
code_assignt assign(it->lhs_object, it->lhs_object_value);
irep_idt identifier=it->lhs_object.get_identifier();
val.data=convert_assign_rec(identifier, assign);

xmlt &val_s=edge.new_element("data");
val_s.set_attribute("key", "assumption.scope");
val_s.data=id2string(it->pc->source_location.get_function());
}
xmlt &val=edge.new_element("data");
val.set_attribute("key", "assumption");
val.data=from_expr(ns, it->pc->function, it->full_lhs)+" = "+
from_expr(ns, it->pc->function, it->full_lhs_value)+";";

xmlt &val_s=edge.new_element("data");
val_s.set_attribute("key", "assumption.scope");
val_s.data=id2string(it->pc->source_location.get_function());
}
else if(it->type==goto_trace_stept::typet::GOTO &&
it->pc->is_goto())
Expand Down