Cleanup asserts - replace with invariants #2891
Conversation
sonodtt
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
|
|
||
| #include <ostream> | ||
|
|
||
| #include "invariant.h" |
There was a problem hiding this comment.
This was deleted because the corresponding header already includes invariant.h. I'm not a huge fan of this change myself, but it's not harmful.
| #include <vector> | ||
|
|
||
| #include "deprecate.h" | ||
| #include "invariant.h" |
There was a problem hiding this comment.
Please remove the cassert header now that this move is taking place.
There was a problem hiding this comment.
Ah yes. Done. Also in other PRs.
sonodtt
force-pushed
the
invariant-cleanup-util_dir-irep_h_cpp
branch
from
9b689d9 to
38d41c9
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 9b689d9).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
sonodtt
force-pushed
the
invariant-cleanup-util_dir-irep_h_cpp
branch
from
38d41c9 to
f0522e7
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: f0522e7).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: f0522e7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/83975679
4 participants
Remove all
assert()statements, replacing with appropriateINVARIANT,PRECONDITION, etc.The target files for PR have no throw statements - no cleanup required w.r. to throw statements.