Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Jan 7, 2019

The semantics of signed left shifts are contentious for the case
that a '1' is shifted into the signed bit. This tests the C99 case.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The semantics of signed left shifts are contentious for the case
that a '1' is shifted into the signed bit. This tests the C99 case.
@kroening kroening force-pushed the test-overflow-leftshift-c99 branch from d4a8065 to ba34966 Compare January 7, 2019 17:40
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: ba34966).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96508556

@kroening kroening merged commit f3793bd into develop Jan 7, 2019
@kroening kroening deleted the test-overflow-leftshift-c99 branch January 7, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants