Skip to content

Conversation

@kroening
Copy link
Collaborator

This adds support for parsing SMT-LIB2 to_fp expressions that use a numeral.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds support for parsing SMT-LIB2 to_fp expressions that use a numeral.
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #6059 (7e7d992) into develop (ff5902e) will decrease coverage by 0.33%.
The diff coverage is 85.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6059      +/-   ##
===========================================
- Coverage    74.25%   73.92%   -0.34%     
===========================================
  Files         1444     1444              
  Lines       157460   157481      +21     
===========================================
- Hits        116928   116415     -513     
- Misses       40532    41066     +534     
Impacted Files Coverage Δ
src/goto-instrument/code_contracts.h 94.11% <ø> (ø)
src/solvers/flattening/boolbv.cpp 80.00% <0.00%> (+0.47%) ⬆️
src/solvers/flattening/boolbv_case.cpp 0.00% <0.00%> (ø)
src/solvers/flattening/boolbv_cond.cpp 0.00% <0.00%> (ø)
src/solvers/prop/prop.cpp 42.85% <0.00%> (-42.86%) ⬇️
src/solvers/prop/prop.h 84.37% <ø> (ø)
src/solvers/sat/cnf.h 83.33% <ø> (ø)
src/util/irep.h 93.47% <ø> (ø)
src/util/std_expr.h 92.08% <ø> (-0.56%) ⬇️
src/solvers/smt2/smt2_parser.cpp 73.38% <78.78%> (+2.56%) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc30727...7e7d992. Read the comment docs.

@kroening kroening marked this pull request as ready for review April 27, 2021 21:14
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth also adding a satisfiable test?

@kroening
Copy link
Collaborator Author

Is it worth also adding a satisfiable test?

These add value when there's any risk of overconstraining; the feature at hand produces a constant expression.

@kroening kroening merged commit ce32507 into develop Apr 28, 2021
@kroening kroening deleted the smt2_parser_fp branch April 28, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants