C nondet factory: Ensure parameter initialisers use unique symbol names #6569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6569 +/- ##
===========================================
- Coverage 76.01% 76.01% -0.01%
===========================================
Files 1579 1579
Lines 181304 181288 -16
===========================================
- Hits 137819 137799 -20
- Misses 43485 43489 +4
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
Jan 12, 2022
kroening
approved these changes
Jan 12, 2022
The nondet symbol factory uses "tmp" as a default basename prefix, and in all other places already generated unique names using `get_fresh_aux_symbol`. This function, however, will happily use exactly that basename when there wouldn't be a conflict. The code fixed in this commit, however, did not yet use this facility, and just assumed that each parameter of the target function would result in a unique local name. A parameter named "tmp," then, resulted in a conflict. Consistently using `get_fresh_aux_symbol` addresses this problem. Fixes: diffblue#6566 Co-authored-by: Matthias Güdemann <matthias.guedemann@hm.edu> fixup! C nondet factory: Ensure parameter initialisers use unique symbol names
tautschnig
force-pushed
the
bugfixes/6566
branch
from
79485d6 to
89b8bbc
Compare
Use references and symbol names to track created symbols rather than pointers. This avoids the risk of dereferencing pointers to objects that have been deallocated by the time dereferencing takes place. This is just defensive programming, no known bugs fixes or changes in behaviour intended.
tautschnig
force-pushed
the
bugfixes/6566
branch
from
89b8bbc to
de5bbd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nondet symbol factory uses "tmp" as a default basename prefix, and
in all other places already generated unique names using
get_fresh_aux_symbol. This function, however, will happily use exactlythat basename when there wouldn't be a conflict. The code fixed in this
commit, however, did not yet use this facility, and just assumed that
each parameter of the target function would result in a unique local
name. A parameter named "tmp," then, resulted in a conflict.
Consistently using
get_fresh_aux_symboladdresses this problem.Fixes: #6566
Co-authored-by: Matthias Güdemann matthias.guedemann@hm.edu