Quantifiers with multiple bindings #6585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kroening
commented
Jan 17, 2022
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
This adds support for pretty-printing forall/exists expressions that have multiple bindings.
This adds support for converting forall/exists expressions that have multiple bindings to SMT2.
This adds convenience constructors for forall/exists expressions with multiple bindings.
The simplifier can now simplify !exists and !forall with multiple bindings.
kroening
force-pushed
the
quantifier-multi-binding
branch
from
59205b7 to
b165bf9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6585 +/- ##
===========================================
+ Coverage 76.19% 76.21% +0.01%
===========================================
Files 1578 1578
Lines 181276 181392 +116
===========================================
+ Hits 138132 138249 +117
+ Misses 43144 43143 -1
Continue to review full report at Codecov.
|
kroening
requested review from
NlightNFotis,
TGWDB,
martin-cs,
peterschrammel,
tautschnig and
thomasspriggs
as code owners
TGWDB
approved these changes
Jan 18, 2022
Contributor
TGWDB
left a comment
TGWDB
left a comment
There was a problem hiding this comment.
Any chance of some tests of this code?
peterschrammel
approved these changes
Jan 19, 2022
Collaborator
Author
|
Tests are coming in the branch model_refinement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.