Add support for array_exprt to incremental smt2 decision procedure #7004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomasspriggs
commented
Jul 8, 2022
thomasspriggs
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
thomasspriggs
requested review from
NlightNFotis,
TGWDB,
chris-ryder and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7004 +/- ##
========================================
Coverage 77.84% 77.85%
========================================
Files 1569 1569
Lines 180590 180656 +66
========================================
+ Hits 140582 140648 +66
Misses 40008 40008
Continue to review full report at Codecov.
|
NlightNFotis
approved these changes
Jul 11, 2022
esteffin
reviewed
Jul 11, 2022
Contributor
esteffin
left a comment
esteffin
left a comment
There was a problem hiding this comment.
All good to me.
Just a minor non-blocking comment
| solver_process->send(smt_declare_function_commandt{array_identifier, {}}); | ||
| const std::vector<exprt> &elements = array.operands(); | ||
| const std::size_t index_width = | ||
| array_sort->index_sort().cast<smt_bit_vector_sortt>()->bit_width(); |
Contributor
There was a problem hiding this comment.
⛏️
array_sort->index_sort() is never enforced to be of smt_bit_vector_sortt type (although we don't use other types).
I suggest adding and INVARIANT to ensure the cast is safe
This means that there will be fewer changes required if we ever change the encoding of arrays such that they do not have a bit vector sorted index. It also means that there is no need to add an invariant for this previously implicitly assumed property.
esteffin
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.