-
Notifications
You must be signed in to change notification settings - Fork 12
Update tests with ordered properties #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba40074 to
fb79be3
Compare
chrisr-diffblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the submodule bump will need updating once diffblue/cbmc#5214 has actually been merged? We need the submodule pointing at cbmc/develop so that everyone/anyone can access the appropriate commit when building gnat2goto. I'll put a blocking review on just until the submodule gets bumped, but other than that, looks good.
fb79be3 to
166a788
Compare
|
@chrisr-diffblue now pointing at |
xbauch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
chrisr-diffblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, now the submodule points at develop - many thanks.
|
@chrisr-diffblue @martin-cs I don't have write access. Not sure if I should, but this is ready to merge :) |
|
@thk123 Argh, apologies - I thought I'd added you to the appropriate group, but it turns out I hadn't actually clicked the extra "yes, I really do mean to do this" button. You should now have received an invite from Github. |
Brings in diffblue/cbmc#5214
Previously propreties that differed only by name would be in a undefined order. Now they are sorted first by name, then by number. Expected output is updated accordingly.