Verilog: use zero_extend_exprt
#1302
Merged
+55
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
verilog_zero_extend_exprt
branch
2 times, most recently
from
9248e11 to
cb249de
Compare
tautschnig
reviewed
Oct 9, 2025
src/verilog/verilog_lowering.cpp
Outdated
| else | ||
| return expr; | ||
| } | ||
| else if(expr.id() == ID_zero_extend) |
There was a problem hiding this comment.
So why is this lowering required? Shouldn't the back-end be capable of handling zero_extend?
There was a problem hiding this comment.
The back-end is missing some cases; I'll separate.
There was a problem hiding this comment.
The non-four-valued cases now work without lowering after updating to cbmc 5.7.1.
There was a problem hiding this comment.
Will the four-valued cases be covered in a separate PR?
There was a problem hiding this comment.
Yes, will do separate PR
kroening
force-pushed
the
verilog_zero_extend_exprt
branch
3 times, most recently
from
50c5683 to
43465a0
Compare
This replaces a custom encoding via typecast_exprt used in the Verilog front-end by zero_extend_exprt. To support --smv-word-level, conversion for zero_extend is added to expr2smv.
kroening
force-pushed
the
verilog_zero_extend_exprt
branch
from
43465a0 to
653b73b
Compare
tautschnig
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a custom encoding via
typecast_exprtused in the Verilog front-end byzero_extend_exprt.