SMV: word constants #1389
Merged
SMV: word constants #1389
+170
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smv-word-constants
branch
5 times, most recently
from
2aa4e08 to
d128ef8
Compare
tautschnig
approved these changes
Nov 6, 2025
src/smvlang/smv_typecheck.cpp
Outdated
Comment on lines
699
to
701
| auto result = from_integer(digits_int, type); | ||
| result.add_source_location() = src_expr.source_location(); | ||
| return result; |
Collaborator
There was a problem hiding this comment.
Suggested change
| auto result = from_integer(digits_int, type); | |
| result.add_source_location() = src_expr.source_location(); | |
| return result; | |
| return from_integer(digits_int, type).with_source_location(src_expr.source_location()); |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately won't work since we are returning a constant_exprt.
Collaborator
There was a problem hiding this comment.
Then we should add with_source_location to constant_exprt (as we already have for some others)! (Obviously not a blocker for this PR here).
Collaborator
Author
There was a problem hiding this comment.
Changed return type to exprt
This adds NuSMV's word constants to scanner, parser, type checker.
kroening
force-pushed
the
smv-word-constants
branch
from
d128ef8 to
38db215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds NuSMV's word constants to scanner, parser, type checker.