copy language_file.cpp and language_file.h from CBMC #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
copy-language-file
branch
from
c5af823 to
4a83abf
Compare
The logic implemented in CBMC's language_filest class typechecks modules starting from the leaves of the dependency tree. This is an ill-fit for both SMV and Verilog, which expect elaboration and type checking to start from the root (or "main") module. This copies the file that contains the langauge_filet and language_filest classes in order to make this change locally.
kroening
force-pushed
the
copy-language-file
branch
from
4a83abf to
6f96868
Compare
tautschnig
approved these changes
Nov 17, 2025
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Is a next step to clean up some module-related references in the CBMC code base?
Collaborator
Author
Yes, will clean out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic implemented in CBMC's
language_filestclass typechecks modules starting from the leaves of the dependency tree. This is an ill-fit for both SMV and Verilog, which expect elaboration and type checking to start from the root (or "main") module.This copies the file that contains the
langauge_filetandlanguage_filestclasses in order to make this change locally.