Skip to content

Refactor conversions from primitive types to String #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danpoe merged 3 commits into from
Sep 9, 2019
Merged

Refactor conversions from primitive types to String #27

danpoe merged 3 commits into from
Sep 9, 2019

Conversation

@danpoe
Copy link
Contributor

@danpoe danpoe commented Aug 21, 2019

No description provided.

@romainbrenguier
Copy link
Contributor

romainbrenguier commented Aug 22, 2019

There should be first a pull request on CBMC to add the CProverString.toString function to the preprocessing (can be merged without this one if it includes some test). Then this one can be merged (there should also be a similar one for the models library). Then you can make one in CBMC to remove the preprocessing of the non-CProverString functions.

@danpoe danpoe force-pushed the danpoe/refactor/primitive-types-to-string branch 3 times, most recently from 7b8201d to 10e906c Compare August 28, 2019 13:06
danpoe added a commit to danpoe/cbmc that referenced this pull request Aug 28, 2019
@danpoe
Update java-models-library to diffblue/java-models-library#27
d08c8c6
danpoe added a commit to danpoe/cbmc that referenced this pull request Aug 29, 2019
@danpoe
Update java-models-library to diffblue/java-models-library#27
d7963b9
danpoe added a commit to danpoe/cbmc that referenced this pull request Aug 30, 2019
@danpoe
Update java-models-library to diffblue/java-models-library#27
21ee1e8
@danpoe danpoe force-pushed the danpoe/refactor/primitive-types-to-string branch 2 times, most recently from 1fc7752 to d47727c Compare September 9, 2019 10:55
danpoe added a commit to danpoe/cbmc that referenced this pull request Sep 9, 2019
@danpoe
Update java-models-library to diffblue/java-models-library#27
ba69aec
danpoe added a commit to danpoe/cbmc that referenced this pull request Sep 9, 2019
@danpoe
Update java-models-library to diffblue/java-models-library#27
1000a9e
@danpoe danpoe removed the don't merge label Sep 9, 2019
@danpoe danpoe merged commit b545958 into master Sep 9, 2019
@rjmunro rjmunro deleted the danpoe/refactor/primitive-types-to-string branch September 11, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danpoe @romainbrenguier @peterschrammel