Introduce and use CProverString.isValidInt/Long #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These determine whether a string would pass parseInt/parseLong without throwing due to containing inappropriate characters. The previous versions were broken because that check was a mandatory part of Integer.parseInt and cousins, causing side-effects on the input string.
peterschrammel
approved these changes
Feb 11, 2020
romainbrenguier
approved these changes
Feb 11, 2020
| * radix is already checked in-range. | ||
| * Exactly as Integer.parseInt, except s is already checked non-null, the | ||
| * radix is already checked in-range and 's' is known to be a valid integer | ||
| * according to isValidInt below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These determine whether a string would pass parseInt/parseLong without throwing due to
containing inappropriate characters. The previous versions were broken because that check
was a mandatory part of Integer.parseInt and cousins, causing side-effects on the input
string.