fix: restore dark mode contrast in Cloud settings#1410
Merged
Conversation
Replace hard-coded light fills in the Cloud settings panel with design-system tokens so badges, pills, and outline controls keep readable contrast in dark mode.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Fix note: the unreadable controls were coming from hard-coded light backgrounds in |
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
Replace hard-coded light fills in the Cloud settings panel with design-system tokens so badges, pills, and outline controls keep readable contrast in dark mode.
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
Replace hard-coded light fills in the Cloud settings panel with design-system tokens so badges, pills, and outline controls keep readable contrast in dark mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DenSettingsPanelbadges, pills, notices, and quiet controls with design-language tokens so the Cloud tab stays readable in dark mode.Settings > Cloudonly.apps/app/pr/and embed them below for review.Verification
packaging/docker/dev-up.sh.Settings > Cloudin dark mode, seeded a mocked signed-in Cloud state in-browser to reproduce the signed-in/no-org UI deterministically, and captured before/after screenshots.smoke: hello from chrome mcpin the running app and gotHello! Connection received. How can I help you today?.docker compose -p openwork-dev-6aaca973 -f packaging/docker/docker-compose.dev.yml exec -T web sh -lc 'pnpm --filter @openwork/app typecheck'docker compose -p openwork-dev-6aaca973 -f packaging/docker/docker-compose.dev.yml exec -T web sh -lc 'pnpm --filter @openwork/app build'docker compose -p openwork-dev-6aaca973 -f packaging/docker/docker-compose.dev.yml exec -T web sh -lc 'pnpm --filter @openwork/app test:health'(fails in the dev container becauseopencodeis not onPATH:spawn opencode ENOENT)Screenshots
Before
After