fix(i18n): restore share_skill_destination strings for en and fr#1466
Merged
Conversation
The skill-destination modal shown when importing a shared skill rendered raw translation keys (e.g. 'share_skill_destination.add_to_workspace') for five strings in English and French. Those entries were stubbed with their own keys as values in a previous i18n cleanup and never replaced with real copy. Restore proper English copy (reusing the wording already present for the sibling '_desc' / 'confirm_button' / 'confirm_busy' keys that these hint/CTA keys supersede) and mirror it in French. Other locales already had real translations for these keys and are unaffected.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
The skill-destination modal shown when importing a shared skill rendered raw translation keys (e.g. 'share_skill_destination.add_to_workspace') for five strings in English and French. Those entries were stubbed with their own keys as values in a previous i18n cleanup and never replaced with real copy. Restore proper English copy (reusing the wording already present for the sibling '_desc' / 'confirm_button' / 'confirm_busy' keys that these hint/CTA keys supersede) and mirror it in French. Other locales already had real translations for these keys and are unaffected.
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
The skill-destination modal shown when importing a shared skill rendered raw translation keys (e.g. 'share_skill_destination.add_to_workspace') for five strings in English and French. Those entries were stubbed with their own keys as values in a previous i18n cleanup and never replaced with real copy. Restore proper English copy (reusing the wording already present for the sibling '_desc' / 'confirm_button' / 'confirm_busy' keys that these hint/CTA keys supersede) and mirror it in French. Other locales already had real translations for these keys and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill-destination modal (shown when importing a shared skill via a share link or deep link) was rendering raw translation keys like
share_skill_destination.add_to_workspacein the primary CTA and related labels for English and French users.Five keys were stubbed in a previous i18n cleanup (#1345) with their own key names as the translation value, and
fr.tsinherited the same stubs when it was added. All other locales (ca, es, ja, pt-BR, th, vi, zh) already have real translations and are unaffected.Keys restored
share_skill_destination.add_to_workspaceshare_skill_destination.addingshare_skill_destination.connect_remote_hintshare_skill_destination.create_worker_hintshare_skill_destination.more_optionsThe wording for the hint/CTA keys mirrors the existing
confirm_button,confirm_busy,create_worker_desc, andconnect_remote_descentries that these newer keys supersede inapps/app/src/app/bundles/skill-destination-modal.tsx.Scope
apps/app/src/i18n/locales/en.ts,apps/app/src/i18n/locales/fr.tsVerification
grepthat no locale still has anyshare_skill_destination.*value equal to its own key (pattern"<key>": "<key>").apps/app/src/app/bundles/skill-destination-modal.tsxare defined inen.tsandfr.ts.packaging/docker/dev-up.shhttps://openwork.so/share/<id>link for a shared skill and click "Open in OpenWork", or fire a bundle deep link.Screenshot reference (pre-fix)
Reporter's screenshot showed the CTA rendered as
share_skill_destination.add_to_workspacein English.