fix(extensions): show directory-based project plugins#1535
Merged
src-opn merged 4 commits intoMay 4, 2026
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@pascalandr is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
src-opn
requested changes
Apr 29, 2026
Collaborator
src-opn
left a comment
There was a problem hiding this comment.
Requesting changes.
Finding:
apps/app/src/react-app/domains/settings/state/extensions-store.ts:1306andapps/app/src/react-app/domains/settings/pages/plugins-view.tsx:250-267: directory-discovered project plugins are now added topluginListas bare strings, butpluginListdoes not preserve each item'ssource. The Plugins UI renders every entry with the sameEnabledstate andRemoveaction, andremovePlugin()only removes config-backed plugins fromopencode.json/DELETE /workspace/:id/plugins/:name. For adir.projectitem, clicking Remove will either reportPlugin not foundor refresh back to the same item, which makes the new visible plugin look removable when it is not. Please preserve plugin metadata in state or otherwise render directory plugins read-only / source-aware, and only enable removal for config-backed plugins.
Verification performed:
git diff --check origin/dev...HEAD- byte-level scan of the changed patch for non-ASCII/control/Bidi/BOM characters
pnpm install --frozen-lockfilepnpm --filter @openwork/app typecheckpnpm --filter @openwork/app build
Contributor
Author
|
Made directory plugins visible but read-only, and kept Remove only for config plugins. |
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(extensions): show directory-based project plugins * fix(extensions): make discovered plugins read-only
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(extensions): show directory-based project plugins * fix(extensions): make discovered plugins read-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1105 by updating the Extensions settings store to include all project-scoped plugins returned by
openworkClient.listPlugins(...), deduped by spec, instead of only showing plugins whose source isconfig.Testing
git diff --check upstream/dev...fix/1105-local-plugin-visibilityOKpnpm --filter @openwork/app typecheckcould not provide a clean signal in this environment due local TypeScript install issues (react-router-dom,lucide-react,zustand,@tanstack/react-virtualmissing) plus an existingstreamdown/ React types mismatchNotes