fix(cloud): avoid blank screen during signin check#1539
Merged
src-opn merged 3 commits intoApr 29, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@pascalandr is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(cloud): avoid blank screen during signin check * fix(cloud): surface signin while boot overlay waits
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(cloud): avoid blank screen during signin check * fix(cloud): surface signin while boot overlay waits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1488
This PR ports the conservative pre-cutover sign-in fix into the React shell by rendering
ForcedSigninPageinapps/app/src/react-app/shell/app-root.tsxwhilerequireSignin && denAuth.status === "checking"instead of returningnull.Testing
git diff --check upstream/dev...fix/1488-blank-screen-while-signin-checkingOKpnpm --filter @openwork/app typecheckcould not provide a clean signal in this environment due local TypeScript install issues:react-router-domlucide-reactzustand@tanstack/react-virtualstreamdown/ React types mismatchNotes
This is the React port of the local fix used before the shell cutover, but the current React shell already includes a
LoadingOverlay.