fix(messaging): restore router agent auto-heal in React settings#1540
Merged
src-opn merged 4 commits intoMay 4, 2026
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@pascalandr is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
src-opn
requested changes
Apr 29, 2026
Collaborator
src-opn
left a comment
There was a problem hiding this comment.
Requesting changes.
Code issue:
apps/app/src/react-app/domains/settings/state/messaging-view-state.ts:826: the polling effect depends onrefreshAll, butrefreshAlldepends on state that it mutates (refreshing,messagingEnabled, agent state) and the effect immediately callsrefreshAll({ force: true }). Each refresh can change the callback identity, re-run the effect, clear/recreate the interval, and immediately start another forced refresh instead of waiting for the 10s poll. On a connected settings page this can turn into a continuous config/router/file refresh loop. Please make the polling effect stable so refresh state changes do not retrigger an immediate forced refresh.
Verification run:
pnpm install --frozen-lockfilepassed.pnpm --filter @openwork/app typecheckpassed.pnpm --filter @openwork/app buildpassed, with the existing large chunk warning.pnpm --filter @openwork/app test:healthpassed.
…t-autoheal # Conflicts: # apps/app/src/react-app/shell/settings-route.tsx
Contributor
Author
|
Stabilized the messaging refresh poll so state changes no longer retrigger immediate forced refreshes. |
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(messaging): auto-heal missing router agent file * fix(messaging): restart the router for messaging recovery
benjaminshafii
pushed a commit
that referenced
this pull request
May 15, 2026
* fix(messaging): auto-heal missing router agent file * fix(messaging): restart the router for messaging recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/app/src/react-app/shell/settings-route.tsxwith the realMessagingViewwired to live OpenWork router state.apps/app/src/react-app/domains/settings/state/messaging-view-state.ts, including the old auto-heal path that creates.opencode/agents/opencode-router.mdwhen messaging is enabled and the agent file is missing.Testing
git diff --check upstream/dev...fix/1138-router-agent-autohealOKgit diff --cached --check -- apps/app/src/react-app/domains/settings/state/messaging-view-state.ts apps/app/src/react-app/shell/settings-route.tsxOK while resolving the mergepnpm --filter @openwork/app typecheckcould not provide a clean signal in this environment due local TypeScript install issues (react-router-dom,lucide-react,zustand,@tanstack/react-virtualmissing) plus an existingstreamdown/ React types mismatchNotes