fix deleted session hang and ram leak#1597
Open
Myestery wants to merge 1 commit intodifferent-ai:devfrom
Open
Conversation
When the active session was deleted, SessionPage stayed mounted on the dead id. The 3s title poll swallowed 404s and kept running, the workspace event sync stayed subscribed, and the sidebar showed the stale entry during the refetch window — so clicking it remounted against a missing session and pinned the UI. onDeleteSession now optimistically filters the session out of the sidebar list and navigates to /session (when the deleted session was active) before issuing the HTTP DELETE. Navigating synchronously flips selectedSessionId to null, which fires trackWorkspaceSessionSync cleanup and drops the React Query caches. refreshRouteState still runs afterwards to reconcile with the server. refreshSelectedSessionTitle now treats a 404 (or missing item) as a deleted session: it cancels the interval, removes the session from the sidebar list, and navigates back to /session instead of looping forever.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@Myestery is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1598
Summary
SessionPagemounted on the dead id; the 3s title poll swallowed 404s and the workspace event sync stayed subscribed → UI hang + unbounded RAM growth when the stale tab was clicked again.onDeleteSessionnow optimistically filters the session from the sidebar list and navigates to/session(when active) before the HTTP DELETE, sotrackWorkspaceSessionSynccleanup fires immediately and React Query caches drop.refreshRouteStatestill reconciles afterwards.refreshSelectedSessionTitletreats 404 / missing item as deletion: cancels the interval, removes the session from the sidebar list, and navigates back to/sessioninstead of polling forever.Test plan
/session, sidebar entry disappears immediately, no furthergetSessionrequests for A in network tab./session/{nonexistent-id}→ route auto-redirects to/sessionafter first 404; no infinite poll./session/{deleted}for 1 minute (forced) → heap stable in Chrome devtools Memory.pnpm typecheckinapps/apppasses.Before
hanging.mp4
After
fixed.mp4