fix slack router send fan-out#1633
Open
shizhigu wants to merge 1 commit intodifferent-ai:devfrom
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@shizhigu is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
shizhigu
force-pushed
the
codex/slack-test-direct-send
branch
from
9a86523 to
68a234b
Compare
shizhigu
force-pushed
the
codex/slack-test-direct-send
branch
from
68a234b to
c5a8d65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slack sends through the OpenWork router API can pass a workspace directory without a peerId. The router treats directory-only sends as fan-out to every bound conversation, so a test send can reach more Slack channels than the user selected. This PR keeps that router primitive, but makes the OpenWork Slack send path require a concrete peer target.
Fixes #1139.
What changed
/opencode-router/sendrequests withoutpeerIdat the server-v2 product service.RouteErrorresponse from the router send compatibility handler.Test plan
pnpm --filter openwork-server-v2 exec bun test src/managed.test.tspnpm --filter openwork-server-v2 testpnpm --filter openwork-server-v2 typecheckpnpm --filter openwork-server-v2 build:bingit diff --checkNotes
No app UI changes in this PR. Current
devexposes this behavior through the server-v2 compatibility API, so screenshots would not add useful evidence.