Skip to content

fix(server): resolve artifacts not shown due to lack of absolute path handling#1964

Merged
benjaminshafii merged 1 commit into
devfrom
fix/resolve-artifacts-not-shown
May 26, 2026
Merged

fix(server): resolve artifacts not shown due to lack of absolute path handling#1964
benjaminshafii merged 1 commit into
devfrom
fix/resolve-artifacts-not-shown

Conversation

@JeanMeijer
Copy link
Copy Markdown
Collaborator

Summary

  • Allows artifact target resolution to accept absolute file paths when they are inside the workspace, converting them back to workspace-relative paths.
  • Skips absolute paths that point outside the workspace.
  • Updates the artifact files E2E test to cover absolute in-workspace paths and preserve the higher confidence score when duplicate targets resolve to the same file.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-app Ready Ready Preview, Comment May 26, 2026 3:06pm
openwork-den Ready Ready Preview, Comment May 26, 2026 3:06pm
openwork-den-worker-proxy Ready Ready Preview, Comment May 26, 2026 3:06pm
openwork-landing Ready Ready Preview, Comment, Open in v0 May 26, 2026 3:06pm
openwork-share Error Error May 26, 2026 3:06pm

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Copy link
Copy Markdown
Member

@benjaminshafii benjaminshafii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via automated Daytona Electron smoke test (agent). Tested: Electron boot, app render, settings navigation, back-to-app. All passed, no regressions detected.

@benjaminshafii benjaminshafii merged commit 3927844 into dev May 26, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants