Skip to content

fix den-v2 desktop auth handoff parity#976

Merged
OmarMcAdam merged 3 commits intodevfrom
task/den-v2-desktop-auth
Mar 17, 2026
Merged

fix den-v2 desktop auth handoff parity#976
OmarMcAdam merged 3 commits intodevfrom
task/den-v2-desktop-auth

Conversation

@OmarMcAdam
Copy link
Collaborator

Summary

  • port the desktop auth handoff endpoints from services/den into services/den-v2 so desktop sign-in works on the Daytona-first control plane too
  • register the new /v1/auth router in services/den-v2/src/index.ts
  • add the desktop_handoff_grant SQL migration required by the new handoff exchange flow

Validation

  • compared services/den/src/http/desktop-auth.ts against den-v2 and ported the missing flow
  • npm run build in services/den-v2

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-den Ready Ready Preview, Comment Mar 17, 2026 6:02pm
openwork-den-worker-proxy Ready Ready Preview, Comment Mar 17, 2026 6:02pm
openwork-landing Ready Ready Preview, Comment, Open in v0 Mar 17, 2026 6:02pm
openwork-share Ready Ready Preview, Comment Mar 17, 2026 6:02pm

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

@OmarMcAdam
Copy link
Collaborator Author

Root cause note for reviewers:\n\n- was originally introduced in by ().\n- During the later shared-schema refactor that moved Den DB ownership into , that table definition did not get carried over.\n- The desktop auth routes still expected the table to exist, so missed the handoff flow entirely and the shared schema no longer matched the route implementation.\n- This PR restores in , updates both Den services to consume the shared definition, and keeps the handoff migration in place so the database can be brought back in sync.\n- I also disabled the and GitHub workflows here because Render is now the source of truth for Den builds/deploys.

@OmarMcAdam
Copy link
Collaborator Author

Root cause note for reviewers:

  • DesktopHandoffGrantTable was originally introduced in services/den/src/db/schema.ts by commit 6143397e (feat(den): hand off desktop auth through the web).
  • During the later shared-schema refactor that moved Den DB ownership into packages/den-db, that table definition did not get carried over.
  • The desktop auth routes still expected the table to exist, so den-v2 missed the handoff flow entirely and the shared schema no longer matched the route implementation.
  • This PR restores DesktopHandoffGrantTable in packages/den-db, updates both Den services to consume the shared definition, and keeps the den-v2 handoff migration in place so the database can be brought back in sync.
  • I also disabled .github/workflows/deploy-den.yml and .github/workflows/deploy-den-v2.yml here because Render is now the source of truth for Den builds and deploys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant