[Audio] Properly fix audio distortion#40
Merged
differrari merged 1 commit intodifferrari:mainfrom Sep 9, 2025
Merged
Conversation
Owner
|
I either misinterpreted the spec, or the spec is wrong, but either way, this does seem to fix it, thank you for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining distortion present in audio output through virtio manifested as 2 extra random-valued samples at the end of each buffer. This was due to an erroneous value for packet_size calculated when the output stream was configured.
Debugged and tested under Windows/WSL using Audacity to capture and inspect the audio output waveform. It also sounds ok too!