Added a '> ' prompt to the terminal#52
Merged
differrari merged 5 commits intodifferrari:mainfrom Oct 12, 2025
emexos:main
Merged
Added a '> ' prompt to the terminal#52differrari merged 5 commits intodifferrari:mainfrom emexos:main
differrari merged 5 commits intodifferrari:mainfrom
emexos:main
Conversation
Owner
|
PR looks good, great job. can you remove the comments in terminal.cpp? The code is self documenting. I'll approve after |
Contributor
Author
i deleted every comments from me |
differrari
approved these changes
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- some commands like cat /dev/console 100 didn't work
- you could delete the prompt
In this version you (half-)can't delete the promt (you can but thats a other console bug...)
and i added:
If you just press enter, nothing happens, so no 'Unknown command %s with args %s'