Support iTerm2 OSC notifications and terminal bells#57
Merged
Conversation
Dedup AlertManager.notify so OSC progress spam doesn't fire listeners every chunk, fast-path no-OSC chunks in TerminalProtocolParser, and collapse the duplicate display-side parser in the vscode-ext router so each PTY chunk is parsed once. Replace ad-hoc ternary cascades in parseOsc94 and TerminalPaneHeader with lookup tables, and derive ACTIVITY_NOTIFICATION_SOURCES from a single const tuple. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extract setProtocolRinging / clearProtocolRingIfActive helpers to remove five copies of the ringing-clear block. Add a no-op guard so repeated OSC 9;4 progress updates skip listener notification. In the OSC parser, fast-path stripDeviceAttributeQueries when no DA query is present, and replace findOscTerminator's allocate+sort with three indexOf compares. Make ALERT_BUTTON_LABELS exhaustive over SessionStatus so adding a new status forces a label decision. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
39e290c
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSC 9,OSC 9;4,OSC 99,OSC 777, plus standalone terminalBELnotifications.Testing