Allow partly parallel Maven execution #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This partly fixes Maven execution in parallel forks, because it postpones evaluating of the rootFolder (`user.dir` value) until it is really needed during execution. Without the fix the path could be evaluated in the main process, meaning the `user.dir` is not set correctly to the tested module. It still does not allow reusing of the forks (reuseForks parameter in maven-surefire-plugin and maven-failsafe-plugin), but at least allows parallel execution (forkCount greater than 1). When reusing the forks, the SnapshotSystemJUnit5.finishedAllTests() complains that it was called more than once, so the reuseForks has to be disabled (set to false). This partly fixes diffplug#551. Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
oldium
force-pushed
the
fix/parallel-run
branch
from
6afae18 to
6f202a9
Compare
Contributor
Author
|
Something like this? Sorry my ignorance, I know Java pretty well, but I am Kotlin newbie 😅 (nice language features, though) |
Member
|
Perfect! I'll merge and release asap. |
Member
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly fixes Maven execution in parallel forks, because it postpones evaluating of the rootFolder (
user.dirvalue) until it is really needed during execution. Without the fix the path could be evaluated in the main process, meaning theuser.diris not set correctly to the tested module.It still does not allow reusing of the forks (reuseForks parameter in maven-surefire-plugin and maven-failsafe-plugin), but at least allows parallel execution (forkCount greater than 1).
When reusing the forks, the SnapshotSystemJUnit5.finishedAllTests() complains that it was called more than once, so the reuseForks has to be disabled (set to false).
This partly fixes #551.