Prefer using plugin extensions over deprecated conventions

[Goooler]

https://docs.gradle.org/current/userguide/upgrading_version_7.html#all_convention_deprecation

[Goooler]

CC @nedtwigg

[Goooler]

May need to bump VER_GRADLE_min to 7.1 in the future, using conventions will start emitting deprecation warnings in Gradle 8.1, and will be removed in the later Gradle 8 versions.

[nedtwigg]

Roger. If we are throwing warnings that we can't easily workaround with a version check, then I'm happy to bump the minimum.

[Goooler]

@nedtwigg Are you planning to move on Gradle plugin 7? If so can we bump the min Gradle requirement to 7.1 for something like this?

[nedtwigg]

It thought that this

spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JvmLang.java

Lines 37 to 49 in ed88d33

	if (GradleVersion.current().compareTo(GradleVersion.version(SpotlessPlugin.VER_GRADLE_javaPluginExtension)) >= 0) {
	final JavaPluginExtension javaPluginExtension = project.getExtensions().findByType(JavaPluginExtension.class);
	if (javaPluginExtension == null) {
	throw new GradleException(message);
	}
	sourceSets = javaPluginExtension.getSourceSets();
	} else {
	final JavaPluginConvention javaPluginConvention = project.getConvention().findPlugin(JavaPluginConvention.class);
	if (javaPluginConvention == null) {
	throw new GradleException(message);
	}
	sourceSets = javaPluginConvention.getSourceSets();
	}

would let us keep 6.1.1 as our min and not emit warnings. But if we are emitting warnings and its very difficult to workaround, then sure I'm okay with bumping the minimum.

[Goooler]

And 682dcd6.

[nedtwigg]

Thanks!

[nedtwigg]

Published in plugin-gradle 6.18.0.