Make sure the order of formatters is deterministic, fixes #1642#1643
Merged
nedtwigg merged 3 commits intodiffplug:mainfrom Apr 5, 2023
Merged
Make sure the order of formatters is deterministic, fixes #1642#1643nedtwigg merged 3 commits intodiffplug:mainfrom
nedtwigg merged 3 commits intodiffplug:mainfrom
Conversation
Member
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1642 which causes the serialised fingerprint to not be deterministic, as it depends on the order in which the map holding the formatters is iterated.
Using a
LinkedHashMapto hold theFormatterlist solves the problem.@nedtwigg