Skip to content

Add @DisableCachingByDefault as hint why outputs are not cached #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 5 commits into from
Apr 6, 2023
Merged

Add @DisableCachingByDefault as hint why outputs are not cached #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99295fc
Add @DisableCachingByDefault to give a proper hint why task outputs a…
skuzzle Apr 6, 2023
6cf5254
Update changelog of plugin-gradle
skuzzle Apr 6, 2023
2dcd726
Remove extra blank line
skuzzle Apr 6, 2023
fd41613
Update hint.
nedtwigg Apr 6, 2023
029acd6
Put changelog entry in the correct place.
nedtwigg Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugin-gradle/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (starting after version `3.27.0`).

## [Unreleased]
### Fixed
* Added `@DisableCachingByDefault` to `RegisterDependenciesTask`.

## [6.18.0] - 2023-04-06
### Added
Expand Down
4 changes: 3 additions & 1 deletion plugin-gradle/src/main/java/com/diffplug/gradle/spotless/RegisterDependenciesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2022 DiffPlug
* Copyright 2016-2023 DiffPlug
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -31,6 +31,7 @@
import org.gradle.api.tasks.OutputFile;
import org.gradle.api.tasks.TaskAction;
import org.gradle.build.event.BuildEventsListenerRegistry;
import org.gradle.work.DisableCachingByDefault;

import com.diffplug.common.base.Preconditions;
import com.diffplug.common.io.Files;
Expand All @@ -46,6 +47,7 @@
* - When this "registerDependencies" task does its up-to-date check, it queries the task execution graph to see which
* SpotlessTasks are at risk of being executed, and causes them all to be evaluated safely in the root buildscript.
*/
@DisableCachingByDefault(because = "This task coordinates the setup and execution of other tasks, and should not be cached")
public abstract class RegisterDependenciesTask extends DefaultTask {
static final String TASK_NAME = "spotlessInternalRegisterDependencies";

Expand Down