-
Notifications
You must be signed in to change notification settings - Fork 494
[prone] remove failing tech.picnic.error-prone-support
#2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/src/diktat/java/com/diffplug/spotless/glue/diktat/DiktatFormatterFunc.java
Outdated
Show resolved
Hide resolved
CollectorMutability, fix warning StaticImportCollectorMutability, fix warning MissingOverride
b3628e2 to
bdeebe9
Compare
| } | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also rewrite, not spotless, ending up being error prone as well completing the circulation.
Line 34 in 78cc9ed
- org.openrewrite.staticanalysis.MissingOverrideAnnotation
CollectorMutability, fix warning MissingOverridetech.picnic.error-prone-support
bdeebe9 to
2e88ead
Compare
2e88ead to
84d377e
Compare
84d377e to
d972573
Compare
|
have you updated the github version somehow @nedtwigg ? Now its keeping the diff even after forbidden force push.
Now its seems ready consider suppressing all the warnings. |
- diffplug#2745 Signed-off-by: Vincent Potucek <vpotucek@me.com>
d972573 to
6356f50
Compare


tryout reduce warnings for:
StaticImport,NonStaticImport#2743disableAllWarnings=truegoogle/error-prone#5367Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)